Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPENDENCY_REFACTOR] - Fix the view number when canceling old dependency tasks #3343

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[DEPENDENCY_REFACTOR] - Fix the view number when canceling old dependency tasks #3343

merged 1 commit into from
Jun 20, 2024
+1 −1

Conversation

shenkeyao
Copy link
Member

Closes #3342.

This PR:

  • Cancels old dependency tasks starting from latest_voted_view, to fix the issue that many dependency tasks are skipped when canceling.

@shenkeyao shenkeyao merged commit 2957e39 into main Jun 20, 2024
36 checks passed
@shenkeyao shenkeyao deleted the keyao/fix-cancel branch June 20, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszrzasik lukaszrzasik lukaszrzasik approved these changes

@jparr721 jparr721 Awaiting requested review from jparr721

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

Assignees

@jparr721 jparr721

@lukaszrzasik lukaszrzasik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEPENDENCY_REFACTOR] - Fix the view number when canceling old dependency tasks
3 participants
@shenkeyao @lukaszrzasik @jparr721