Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declutter CI Logs #3347

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Declutter CI Logs #3347

merged 3 commits into from
Jun 20, 2024

Conversation

rob-maron
Copy link
Collaborator

@rob-maron rob-maron commented Jun 20, 2024 •
edited
Loading

No linked issue

This PR:

  • Removes the instrument that prints every elliptic curve point for all public keys
  • Removes --verbose for tests. This appears to just make the build itself verbose, which prints out a bunch of rustc data that I don't think we really need. But let me know if I'm missing something
  • Makes some miscellaneous changes to satisfy clippy

@rob-maron rob-maron requested a review from ss-es June 20, 2024 14:55
ss-es
ss-es approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ss-es ss-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rob-maron rob-maron merged commit 590a4f2 into main Jun 20, 2024
36 checks passed
@rob-maron rob-maron deleted the rm/fix-ci-logs branch June 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ss-es ss-es ss-es approved these changes

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rob-maron @ss-es