Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify quorum/da networks #3382

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Unify quorum/da networks #3382

merged 1 commit into from
Jun 27, 2024

Conversation

rob-maron
Copy link
Collaborator

@rob-maron rob-maron commented Jun 25, 2024

No linked issue

This PR:

Unifies quorum/DA networks.

Changes should be mostly cosmetic, but:

  • Also fixes a bug where we might not have been initializing combined networks properly in the examples

Key places to review:

crates/hotshot/src/lib.rs

How to test this PR:

The normal test suite should be fine. As long as it passes those I'm not concerned about these changes breaking anything

Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rob-maron rob-maron merged commit 09987d9 into main Jun 27, 2024
33 of 36 checks passed
@rob-maron rob-maron deleted the rm/unify-networks branch June 27, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants