Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPENDENCY_REFACTOR] - Move all the dependency code into consensus2 #3397

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

shenkeyao
Copy link
Member

Closes #3292.

This PR:

  • Reorganizes functions in the helpers.rs and view_changes.rs files for the consensus task:
    • Moves non-dependency-task functions to task-impls/src/consensus/handlers.rs.
    • Moves functions shared by dependency and non-dependency tasks to task-impls/src/helpers.rs.
  • Gates dependency- and non-dependency-task implementations in hotshot/src/tasks/task_state.rs.
  • Removes redundant feature gates and updates imports.

This PR does not:

  • Change any implementation logic.

Key places to review:

  • Files with pure addition or deletion could be skipped for review, since the changes are mainly function movings that git doesn't recognize.

@bfish713
Copy link
Collaborator

Looks good, I will re-aprove after that's resolved, and CI should be green after merging main

bfish713
bfish713 previously approved these changes Jun 28, 2024
@shenkeyao shenkeyao merged commit 91d8d4e into main Jun 28, 2024
36 checks passed
@shenkeyao shenkeyao deleted the keyao/move-to-consensus2 branch June 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEPENDENCY_REFACTOR] - Move all the dependency code into consensus2
2 participants