Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bundle struct and request bundles in transaction task #3472

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

ss-es
Copy link
Contributor

@ss-es ss-es commented Jul 22, 2024

Closes #3381
Closes #3375

This PR:

  • Adds the Bundle struct
  • Adds a fetch_bundles method to the AuctionResultsProvider trait that retrieves a Bundle from all builders that win a given auction.
  • Adds logic in the transactions task to call fetch_bundles and construct a PackedBundle from multiple builders depending on the version of HotShot in effect.
  • Removes the bid_fees field from PackedBundle.

This PR does not:

Key places to review:

  • task-impls/src/transactions.rs
  • types/src/traits/auction_results_provider.rs

crates/task-impls/src/transactions.rs Outdated Show resolved Hide resolved
crates/task-impls/src/transactions.rs Show resolved Hide resolved
crates/types/src/bundle.rs Show resolved Hide resolved
@ss-es ss-es marked this pull request as ready for review July 25, 2024 14:47
@ss-es ss-es requested a review from bfish713 as a code owner July 25, 2024 14:47
@ss-es ss-es merged commit 765e688 into main Jul 25, 2024
36 checks passed
@ss-es ss-es deleted the ss/marketplace-auction branch July 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants