Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better deserialize_canonical_bytes macro #108

Merged
merged 2 commits into from
Aug 16, 2022
Merged

better deserialize_canonical_bytes macro #108

merged 2 commits into from
Aug 16, 2022

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Aug 16, 2022

Description

Previously, our deserialize_canonical_bytes!() macro only accept MyStruct and MyStruct<'a>, now we can accept arbitrary number of lifetime and generic parameter such as MyStruct<'a, 'b, C: Config, R: Rng, ...>

Blocking: EspressoSystems/cap#64


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@alxiong alxiong merged commit e51a3a7 into main Aug 16, 2022
@alxiong alxiong deleted the alex/serde-generic branch August 16, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants