better deserialize_canonical_bytes macro #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, our
deserialize_canonical_bytes!()
macro only acceptMyStruct
andMyStruct<'a>
, now we can accept arbitrary number of lifetime and generic parameter such asMyStruct<'a, 'b, C: Config, R: Rng, ...>
Blocking: EspressoSystems/cap#64
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.Wrote unit testsPending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer