Bug fixed. logic_or should use LogicOrValueGate

[mrain]

Description

closes: #114

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (main)
• Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
• Wrote unit tests
• Updated relevant documentation in the code
• Added a relevant changelog entry to the Pending section in CHANGELOG.md
• Re-reviewed Files changed in the GitHub PR explorer

[alxiong]

I don't understand, why is there a LogicOrValueGate in the first place? that seems equivalent to LogicOrGate?

impl<F> Gate<F> for LogicOrGate
where
    F: Field,
{
    fn name(&self) -> &'static str {
        "Logic OR Gate"
    }
    fn q_lc(&self) -> [F; GATE_WIDTH] {
        [F::one(), F::one(), F::zero(), F::zero()]
    }
    fn q_mul(&self) -> [F; N_MUL_SELECTORS] {
        [-F::one(), F::zero()]
    }
    fn q_c(&self) -> F {
        -F::one()
    }
}

impl<F> Gate<F> for LogicOrValueGate
where
    F: Field,
{
    fn name(&self) -> &'static str {
        "Logic OR Value Gate"
    }
    fn q_lc(&self) -> [F; GATE_WIDTH] {
        [F::one(), F::one(), F::zero(), F::zero()]
    }
    fn q_mul(&self) -> [F; N_MUL_SELECTORS] {
        [-F::one(), F::zero()]
    }
    fn q_o(&self) -> F {
        F::one()
    }
}

basically LogicOrGate: a+b-ab-1 =0 and LogicOrValueGate: a+b-ab=1, they are the same.

[chancharles92]

I remember we used to have APIs c = logic_or(a, b) and logic_or_gate(c, a, b): the first return a bool variable c that's the logic_or of the inputs; the 2nd API enforces c = a or b. So what's the LogicOrValueGate?

[mrain]

I don't understand, why is there a LogicOrValueGate in the first place? that seems equivalent to LogicOrGate?
basically LogicOrGate: a+b-ab-1 =0 and LogicOrValueGate: a+b-ab=1, they are the same.

Not really the same. For LogicOrValueGate is a+b-ab=output, that's q_o not q_c

I remember we used to have APIs c = logic_or(a, b) and logic_or_gate(c, a, b): the first return a bool variable c that's the logic_or of the inputs; the 2nd API enforces c = a or b. So what's the LogicOrValueGate?

We only have APIs c = logic_or(a, b) and logic_or_gate(a, b). Later one is a hard constraint that a or b must be true.
LogicOrGate corresponds to the later constraint. And LogicOrValueGate is computing the logic or of two input wires.

[chancharles92]

@mrain Is there a better name for LogicOrValueGate and LogicOrGate? How about LogicOrOutputGate and LogicOrConstantGate?

[mrain]

@mrain Is there a better name for LogicOrValueGate and LogicOrGate? How about LogicOrOutputGate and LogicOrConstantGate?

What about LogicOrGate and LogicOrOutputGate? That's clear enough to me.
WDYT @alxiong

[chancharles92]

LGTM