Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light weight merkle tree implementation. #176

Merged
merged 6 commits into from
Jan 9, 2023
Merged

Light weight merkle tree implementation. #176

merged 6 commits into from
Jan 9, 2023

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Jan 3, 2023 •
edited
Loading

Description

closes: #141

Gadget implementation not required.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain mrain linked an issue Jan 3, 2023 that may be closed by this pull request
Light-weight merkle tree implementation #141
Closed
@mrain mrain requested a review from a team January 3, 2023 15:53
chancharles92
chancharles92 reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

primitives/src/merkle_tree/internal.rs Show resolved Hide resolved
primitives/src/merkle_tree/internal.rs Outdated Show resolved Hide resolved
primitives/src/merkle_tree/internal.rs Show resolved Hide resolved
@mrain
Add some comments for the internal function.
b4c66ad 
For light-weight MT, change type to `u64` for internal values.
chancharles92
chancharles92 reviewed Jan 6, 2023
View reviewed changes
primitives/src/merkle_tree/light_weight.rs Show resolved Hide resolved
primitives/src/merkle_tree/light_weight.rs Outdated Show resolved Hide resolved
primitives/src/merkle_tree/internal.rs Show resolved Hide resolved
primitives/src/merkle_tree/internal.rs Outdated Show resolved Hide resolved
@mrain mrain merged commit a394845 into main Jan 9, 2023
@mrain mrain deleted the light-weight-merkle-tree branch January 9, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancharles92 chancharles92 chancharles92 approved these changes

@alxiong alxiong Awaiting requested review from alxiong alxiong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light-weight merkle tree implementation
2 participants
@mrain @chancharles92