Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multilinear PCS opening #177

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Conversation

chancharles92
Copy link
Contributor

@chancharles92 chancharles92 commented Jan 9, 2023

Description

closes: #170


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

alxiong
alxiong previously approved these changes Jan 9, 2023
@chancharles92 chancharles92 dismissed alxiong’s stale review January 9, 2023 20:06

Delay approval until strengthening tests.

@chancharles92 chancharles92 merged commit 5dc3b1a into main Jan 13, 2023
@chancharles92 chancharles92 deleted the pcs-open-refactor-by-170 branch January 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multilinear PCS opening uses too many scalars
2 participants