-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FK23 batch opening of univariate polynomials #231
Conversation
dev log (safely skip for reviewer): I made the wrong decision to make my Toeplitz APIs constant generic rather than just accepting a vector and checking their lengths inside. (the former is good when we know the size at compile-time, the latter is better for dynamic and run-time variables) I will need to update my code cuz the rigidity of const-generic propagate up to where I try to use my own APIs in batch_open, and it's a hustle. Update: fixed in 8e239e1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alxiong! Generally LGTM but added a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew that was big. Minor comments only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm only a couple minor tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, but we can push that to a future issue if we decide it's worth addressing. lgtm.
Log for future referenceI shall document briefly on the slight complication of computing the degree/coeffs for FK23 to work for future reference. Firstly, we are opening a polynomial Now we accept
and for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Hooray!
Description
Partially completes: #118
Major changes include:
PolynomialCommitmentScheme::SRS: StructuredReferenceString
.GeneralDensePolynomial
that allows its coeffs to be either field or group, and implementbatch_evaluate
More important changes when addressing comments:
gen_srs_for_testing
undertest-srs
feature flag (and also available for test) so that downstream and bench code can still use it, but won't be in the default or production-ready binary.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer