-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bytes_from_field_elements
util
#234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few minor comments. There is also a minor clippy warning.
Found the clippy warning and fixed it. It was in |
* implement #250 (comment) * even more rusty than #250 (comment) * refactor compile-time checks as per #234 (comment) * tests for extension fields * pretty rustdoc as requested in #255 (review)
Description
closes: #227
bytes_from_field_elements()
to invertbytes_to_field_elements()
bytes_to_field_elements()
to encode bytes length in the first field element for use in inversionbytes_to_field_elements
and other tidyingPrimeField
toField
String
as error type forbytes_from_field_elements
---should we do something else instead?Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer