-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MerkleTreeGadget implementation #243
Refactor MerkleTreeGadget implementation #243
Conversation
There is still some work to be done in moving some tests around but I wanted first to check if you like the direction of the change. |
Thanks very much for spotting this. It will be very helpful if you proceed ahead. |
Ready for review :) |
@@ -6,330 +6,3 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoule delete this file?
LGTM in general, minor comments above. Also do you think it's better to rename |
@mrain I've addressed all comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot!
Description
There are two implementations of
MerkleTreeGadget
forRescueMerkleTree
andRescueSparseMerkleTree
that are equivalent except types they use. Recently a bug was found in the impl forRescueMerkleTree
that affected also the other and only one was fixed.This PR proposes a refactor to a common implementation for both types.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer