Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive Debug for TaggedBlobError #28

Merged
merged 1 commit into from
Feb 24, 2022
Merged

derive Debug for TaggedBlobError #28

merged 1 commit into from
Feb 24, 2022

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Feb 24, 2022

Description

A super minor modification, reported from downstream:

// This incurs compilation error:
// the method `unwrap` exists for enum `Result<MyStruct, TaggedBlobError>`, but its trait bound were not satisfied
// the following trait bounds were not satisfied:
// `TaggedBlobError: Debug` [E0599] 
let x = MyStruct::from_str(&ser_str).unwrap();

// currently can only do something like:
let x = MyStruct::from_str(&ser_str).unwrap_or_default();

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

Copy link
Contributor

@zhenfeizhang zhenfeizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alxiong alxiong merged commit 9c438ec into main Feb 24, 2022
@alxiong alxiong deleted the fix/tagged-blob-derive branch February 24, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants