-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reed-Solomon decoder accept FFT domain #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrain
reviewed
Jun 8, 2023
Generally LGTM. I think we can close the previous PR and directly merge this one to the main branch. |
mrain
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close: #261
rs-code-fft
instead ofmain
so you can see the stuff I added to Refactor Reed Solomon code #256. If desired we could change the merge target tomain
and close Refactor Reed Solomon code #256.reed_solomon_erasure_decode_rou
accepts FFT domain and wrapsreed_solomon_erasure_decode
.reed_solomon_erasure_encode
into an iterator adaptor. (ie. It now returns an iterator.) It's not obvious/easy to do the same forreed_solomon_erasure_decode
so I didn't do that.Warning
(UPDATE: fixed in 08e870f . See #309 (comment) . )
Naive implementation of
reed_solomon_erasure_decode_rou
computes each eval point in linear time. Ideally we would like constant-time random access to domain points without allocating and populating a vec for all the points. How best to achieve that?jellyfish/primitives/src/reed_solomon_code/mod.rs
Lines 157 to 158 in 8baf5e0
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer