Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding rescue parameters for Bn254 #343

Merged
merged 10 commits into from
Jul 20, 2023
Merged

feat: adding rescue parameters for Bn254 #343

merged 10 commits into from
Jul 20, 2023

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Jul 14, 2023

Description

closes: #342


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain mrain marked this pull request as ready for review July 14, 2023 20:11
@mrain mrain requested a review from chancharles92 July 14, 2023 20:11
Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrain mrain merged commit 072d5d1 into main Jul 20, 2023
3 checks passed
@mrain mrain deleted the rescue-issue branch July 20, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rescue parameter for Fq254
3 participants