Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table domain separation #51

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Table domain separation #51

merged 3 commits into from
Apr 7, 2022

Conversation

chancharles92
Copy link
Contributor

@chancharles92 chancharles92 commented Apr 5, 2022 •
edited
Loading

Description

closes: #48 (and a followup of #47 )

  • Add an error path test: the circuit should be unsatisfiable if the element to be looked up is in a separate table. (Thanks @tri-joe for spotting it)
  • Refactor the code to use Plookup paper's original approach for supporting multiple tables.
  • Removed unnecessary range-check gates in MSM.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@chancharles92 chancharles92 self-assigned this Apr 7, 2022
@chancharles92 chancharles92 merged commit 5eb3059 into main Apr 7, 2022
@chancharles92 chancharles92 deleted the table_dom_sep branch April 7, 2022 22:47
zhenfeizhang pushed a commit that referenced this pull request Apr 12, 2022
@chancharles92 @zhenfeizhang
Table domain separation (#51)
e9b9d2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxiong alxiong alxiong left review comments

@zhenfeizhang zhenfeizhang zhenfeizhang approved these changes

@tri-joe tri-joe Awaiting requested review from tri-joe

Assignees

@chancharles92 chancharles92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lookup tables domain separation
3 participants
@chancharles92 @zhenfeizhang @alxiong