update API: is_xxx to check_xxx when self is mutated #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxiong
reviewed
Apr 13, 2022
plonk/src/circuit/customized/mod.rs
Outdated
| @@ -964,7 +964,7 @@ pub(crate) mod test { | |||
| fn build_is_zero_circuit<F: PrimeField>(a: F) -> Result<PlonkCircuit<F>, PlonkError> { | |||
There was a problem hiding this comment.
we should change these test fn names as well.
There was a problem hiding this comment.
nice catch. Fixed.
zhenfeizhang
deleted the
56-change-all-current-is_xxx-to-check_xxx-and-those-that-enforce-and-will-return-error-if-not-sat-we-keep-using-xxx_gate
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #56
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Wrote unit testsAdded a relevant changelog entry to thePendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer