no_std compliance and refactor SNARK trait #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update Snark -> UniversalSNARK trait * enable CI on PR targetting cap-rollup branch * address Zhenfei's comment
* restore no_std on jf-* * remove HashMap and HashSet for no_std * fix bench.rs, add Display to TaggedBlobError * more no_std fix * put rayon to feature=parallel * use hashbrown for HashMap, update es-commons * simplify rayon-accelerated code
|
@alxiong Is it basically the same PR that we have merged in cap-rollup branch? Do I need to additionally review any new changes? |
|
this is exactly the same as cap-rollup (level with that branch plus a small commit to update CHANGELOG), no need for additional review. @chancharles92 |
chancharles92
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syncing changes made in #80 and #85 to
mainbranchCloses: #84
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Wrote unit testsPendingsection inCHANGELOG.mdRe-reviewedFiles changedin the GitHub PR explorer