Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison gate #96

Merged
merged 15 commits into from
Aug 12, 2022
Merged

Comparison gate #96

merged 15 commits into from
Aug 12, 2022

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Aug 10, 2022

Description

closes: #81


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain
Copy link
Contributor Author

mrain commented Aug 10, 2022

Still incorporating recent changes of Boolean variables.

plonk/src/circuit/customized/mod.rs Outdated Show resolved Hide resolved
plonk/src/circuit/basic.rs Show resolved Hide resolved
plonk/src/circuit/basic.rs Outdated Show resolved Hide resolved
plonk/src/circuit/basic.rs Outdated Show resolved Hide resolved
plonk/src/circuit/basic.rs Show resolved Hide resolved
plonk/src/circuit/basic.rs Outdated Show resolved Hide resolved
plonk/src/circuit/basic.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for @alxiong 's review

plonk/src/circuit/customized/mod.rs Outdated Show resolved Hide resolved
plonk/src/circuit/mod.rs Outdated Show resolved Hide resolved
@mrain mrain changed the title Draft for comparison gate Comparison gate Aug 12, 2022
alxiong
alxiong previously approved these changes Aug 12, 2022
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @chancharles92 maybe you double check the last commit

good job @mrain 👍

Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrain mrain merged commit b79da6f into main Aug 12, 2022
@mrain mrain deleted the chengyu/comparison branch August 12, 2022 19:05
@mrain mrain mentioned this pull request Aug 30, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Constraints]: Comparison gate
3 participants