Fix Error State Issue when Kafka Cluster is Offline #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eironside
reviewed
Jun 3, 2019
kafka-transport/src/main/java/com/esri/geoevent/transport/kafka/KafkaInboundTransport.java
Outdated
Show resolved
Hide resolved
eironside
reviewed
Jun 3, 2019
kafka-transport/src/main/java/com/esri/geoevent/transport/kafka/KafkaInboundTransport.java
Outdated
Show resolved
Hide resolved
eironside
approved these changes
Jun 3, 2019
…e enabling idempotency
hanoch
requested changes
Jun 3, 2019
...ansport/src/main/java/com/esri/geoevent/transport/kafka/KafkaInboundTransportDefinition.java
Outdated
Show resolved
Hide resolved
...ansport/src/main/java/com/esri/geoevent/transport/kafka/KafkaInboundTransportDefinition.java
Outdated
Show resolved
Hide resolved
...ansport/src/main/java/com/esri/geoevent/transport/kafka/KafkaInboundTransportDefinition.java
Outdated
Show resolved
Hide resolved
...-transport/src/main/java/com/esri/geoevent/transport/kafka/KafkaInboundTransportService.java
Outdated
Show resolved
Hide resolved
...nsport/src/main/java/com/esri/geoevent/transport/kafka/KafkaOutboundTransportDefinition.java
Outdated
Show resolved
Hide resolved
|
@mrasante what is the difference between this modified gallery item transport and the OOTB 10.7.1 one? |
hanoch
approved these changes
Jun 11, 2019
|
@mrasante Please move the SDK dependency to the main pom file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a fix to account for cluster state validation prior to starting/restarting.
Also removed libraries that are no longer needed. For situation where a cluster/broker goes down when running, the transport will log an error but remain in the running and will be able to resume operation once the cluster comes back online.