Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build for arm64 and arm32 Linux and arm64 macOS #64

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

theofficialgman
Copy link
Contributor

@theofficialgman theofficialgman commented Feb 5, 2024

closes #23

I am hoping this gets published on itch.io!

See https://github.com/theofficialgman/Celeste64/releases/tag/v1.1.0-arm64 for test build

@theofficialgman theofficialgman changed the title CI: build for arm64 linux CI: build for arm64 Linux and arm64 macOS Feb 5, 2024
@theofficialgman theofficialgman marked this pull request as draft February 5, 2024 23:55
@NoelFB
Copy link
Contributor

NoelFB commented Feb 6, 2024

Looks great, thank you! Yeah I would like to publish these on itch in the near future.
Edit: Oh just realized it's a draft, but I can merge once you're done making modifications.

@theofficialgman theofficialgman changed the title CI: build for arm64 Linux and arm64 macOS CI: build for arm64 and arm32 Linux and arm64 macOS Feb 6, 2024
@theofficialgman
Copy link
Contributor Author

theofficialgman commented Feb 6, 2024

Ready to merge once FosterFramework/Foster#62 is merged and the dependency here is bumped

You can ping me once that PR gets merged and the version in Celeste64 bumped and I can rebase and trigger a final test build before merging this.

@theofficialgman theofficialgman marked this pull request as ready for review February 6, 2024 00:33
@NoelFB
Copy link
Contributor

NoelFB commented Feb 6, 2024

Foster is updated, waiting for NuGet to index 0.1.18

@NoelFB
Copy link
Contributor

NoelFB commented Feb 6, 2024

Looks like it's up now.

@theofficialgman
Copy link
Contributor Author

I am going to switch macOS to an osx-any build (arm64 and x64 in one executable).
Are you able to test that on an x64 or arm64 (preferably both) mac?

@NoelFB
Copy link
Contributor

NoelFB commented Feb 6, 2024

I unfortunately don't have access to a mac at all right now :(
EDIT: But I think doing that in general makes sense, and anyone who has a Mac and runs into problems can bring them up. I'm not going to put the Mac version on itch yet due to various issues.

@NoelFB
Copy link
Contributor

NoelFB commented Feb 6, 2024

Is this good to merge in? I see it's not in draft state anymore but not sure if there's anything else you wanted to tweak!

@theofficialgman
Copy link
Contributor Author

theofficialgman commented Feb 6, 2024

I am going to switch macOS to an osx-any build (arm64 and x64 in one executable). Are you able to test that on an x64 or arm64 (preferably both) mac?

sorry I was mistakem about this. it appears to not be supported automatically as of now dotnet/sdk#9795
since I am not a macos developer and can't even test that I will leave it separate for now

@theofficialgman theofficialgman marked this pull request as ready for review February 6, 2024 01:18
@theofficialgman
Copy link
Contributor Author

tested. all good on ARM32 linux and ARM64 linux

@NoelFB NoelFB merged commit 4a9d220 into ExOK:main Feb 6, 2024
@NoelFB
Copy link
Contributor

NoelFB commented Feb 6, 2024

Awesome, thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM64 Linux support officially
2 participants