-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-23] [$2000] Android - Copy icon is missing in Profile/Contact method #17368
Comments
Triggered auto assignment to @lschurr ( |
Bug0 Triage Checklist (Main S/O)
|
Confirmed, the copy option isn't there on Android, but it is on iOS. |
Triggered auto assignment to @iwiznia ( |
Should this be internal or external @iwiznia? |
Job added to Upwork: https://www.upwork.com/jobs/~0129c789975d0ac1e3 |
Current assignee @lschurr is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
Triggered auto assignment to @NikkiWines ( |
📣 @Balabhadrad! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Format:
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@NikkiWines, @lschurr, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Not overdue. Awaiting proposals |
This comment was marked as off-topic.
This comment was marked as off-topic.
ProposalPlease re-state the problem that we are trying to solve in this issue.Android - Copy icon is missing in Profile/Contact method What is the root cause of that problem?I suspect this behavior is unique to Android and is caused by nesting a App/src/components/CopyTextToClipboard.js Lines 56 to 71 in c144663
The App/src/components/Tooltip/index.js Lines 145 to 149 in c144663
App/src/components/Icon/index.js Lines 54 to 65 in c144663
Interestingly enough, the However, in order to see it, you'll first need to save while in the The icon even responds to click events like it's supposed to whether visible (after it's re-rendered) or invisible (current behavior when app is loaded). Invisible 'copy to clipboard' icon click interactionexpensify-clicking-invisible-copy-icon.movVisible 'copy to clipboard' icon click interactionexpensify-clicking-visible-copy-icon-android.movTo demonstrate further, I tried nesting a different Here's the code I used. //...
{loginMenuItems}
<View>
<Text>
Hello, there
<View>
<Text>I'm nested in a View</Text>
</View>
</Text>
</View>
//... What changes do you think we should make in order to solve the problem?This looks like a bug in React Native that may or may not be related to this currently open React Native Android bug discussing nested I'd suggest not including the 'copy to clipboard' icon on Android devices for the time being, however, the docs forbid contributors from writing platform-specific code, so I think it would be best to leave implementing this at the discretion of Expensify's internal team. Opening an issue with React Native also sounded like a good idea to me. What alternative solutions did you explore?I noticed one of the One of the things I did was add a Hopefully, this provides more insight on Android's tricky behavior. |
Ok cool, thanks @s-alves10. In that case, let's move forward with your proposal. |
@aimane-chnaif @NikkiWines |
@NikkiWines |
@lschurr can we re-post the upwork job for this please 🙇 |
New open job posting is here: https://www.upwork.com/jobs/~01ac7e80f8af912eb4 |
I submitted a proposal. Thank you |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@aimane-chnaif - please apply for the job here: https://www.upwork.com/jobs/~01ac7e80f8af912eb4 Do we need a regression test for this? |
Payment sent to @s-alves10. |
Thank you |
As we implemented workaround, no regression test needed for now. |
Be sure to apply for the job @aimane-chnaif - https://www.upwork.com/jobs/~01ac7e80f8af912eb4 |
Paid with bonuses. Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Copy icon should be displayed near [email protected]
email
Actual Result:
Updated copy icon is missing in Profile/Contact method
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.99.4
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6015417_video_44.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: