-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD facebook/react-native#37397][$1000] Back ticks aren't centered vertically #8132
Comments
Triggered auto assignment to @stitesExpensify ( |
Triggered auto assignment to @mallenexpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
Current assignee @stitesExpensify is eligible for the Exported assigner, not assigning anyone new. |
Proposalin src/styles/styles.js
|
@Phantom-2 , apologies for the delay, @Santhosh-Sellavel can you please review the proposal above? |
Sorry I didn’t leave a comment earlier. |
Also, I tried to reproduce this on my end today, it's not occurring for me. Can you check on the latest staging or production build, is the issue still occurring for you? If reproducible, share me device modal & iOS version, thanks! |
@mvtglobally - Can you have some testers try to reproduce? If if it's not reproducible, agree let's close. |
@mvtglobally was this reproducible? |
@mvtglobally Any update on this? |
Pinged @mvtglobally in NewDot to take a look |
checking, Sorry for the delay. for some reason I missed this one. |
Expensify/react-native#43 is still in process so this one's on hold |
@roryabraham Expensify/react-native#43 was closed, did the solution get moved to facebook/react-native#37397? I'm wondering if this issue should still be on hold for one of those PRs |
@sonialiap @roryabraham Yes, solution was moved to facebook/react-native#37397. Once that PR get approved and merged we will be able to fix this one. We can take either one of the following paths:
|
I think we should still just wait for facebook/react-native#37397. This isn't that big of a deal. |
cc @shawnborton in case you feel differently and we should really change this soon. In which case |
I am cool with waiting. |
No update on facebook/react-native#37397 |
No update |
No update. I think we should just close this for now. Thoughts? |
👋 Can we put the repo/issue we're holding on in the issue title please? Coming here from a dupe and it's easier to follow the dependencies when that's present in the title. Thanks! |
@stitesExpensify do we have any way to push the upstream PR forward? If not, is it worth keeping our issue open when the /react-native hasn't been commented on since June? |
Not really unless we want to divert expert contributor resources to this (which we shouldn't do IMO). I think we should just close this for now and come back to it later. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Back ticks should be centered vertically
Actual Result:
Back ticks aren't centered vertically
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.42-2
![Image from iOS (11)](https://user-images.githubusercontent.com/43995119/158109808-bbbe283d-cb73-4563-a7d3-505044163a61.jpg)
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646420349264159
Upwork: https://www.upwork.com/jobs/~01be27e71047382c31
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: