feat: use pressable with press feedback #19391

BeeMargarida · 2023-05-22T16:08:42Z

Details

Made a new component that uses the already existing withDelayToggleButtonState and makes the logic of showing a checkmark icon and different tooltip text once the pressable was pressed.
- If inline prop is true, it uses Text as a wrapper instead of Pressable, since there are some limitation on RN side regarding that ([SO](https://stackoverflow.com/questions/66590167/vertically-align-pressable-inside-a-text-component, RN issue 1, RN issue 2).
Used new component in CodesPage buttons
Change the already existing CopyTextToClipboard component to use the new component, since it's the same logic

NOTE: the icon in Settings -> Profile -> Contact Method is not being displayed in Android. I checked in main and asked other people if they were experiencing the same, and it seems it's a problem. However, it's not related with this change.

Fixed Issues

$ #19180
#19180 (comment)

Tests

Go to Settings -> Security -> Two-factor authentication
Check that the buttons contain icons and change the icons when pressed
Go to Settings -> Profile -> Contact Method
Check that no regressions in the '[email protected]' clipboard text was made
Go to a chat -> click on the user name
Check that the copy icon next to the email suffered no regression

Verify that no errors appear in the JS console

Offline tests

Not relevant.

QA Steps

Go to Settings -> Security -> Two-factor authentication
Check that the buttons contain icons and change the icons when pressed
Go to Settings -> Profile -> Contact Method
Check that no regressions in the '[email protected]' clipboard text was made
Go to a chat -> click on the user name
Check that the copy icon next to the email suffered no regression

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web_tiny.mp4

Mobile Web - Chrome

mChrome.mov

Mobile Web - Safari

mSafari.mov

Desktop

desktop.mov

iOS

ios_tiny.mp4

Android

android.mov

src/components/PressableWithDelayToggle.js

thiagobrez

LGTM

ArekChr

Overall LGTM 👌

src/components/PressableWithDelayToggle.js

melvin-bot · 2023-05-23T09:06:43Z

@MonilBhavsar @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-05-25T07:46:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-25.at.16.11.51.mov

Mobile Web - Chrome

Screen.Recording.2023-05-30.at.17.56.33.mov

Mobile Web - Safari

Screen.Recording.2023-05-30.at.17.57.05.mov

Desktop

iOS

Screen.Recording.2023-05-25.at.16.20.11.mov

Android

WhatsApp.Video.2023-05-30.at.20.24.31.mp4

rushatgabhane

@BeeMargarida tests well! Request two minor changes

rushatgabhane · 2023-05-25T10:37:49Z

src/components/PressableWithDelayToggle.js

+    /** The icon to display once the pressable is pressed */
+    iconChecked: PropTypes.func,
+
+    /** If the component should be inline with text or not */


This comment should describe when / why would we use this prop

rushatgabhane · 2023-05-25T10:41:05Z

src/components/PressableWithDelayToggle.js

+                containerStyles={styles.flexRow}
+                text={props.isDelayButtonStateComplete ? props.tooltipTextChecked : props.tooltipText}
+            >
+                <Text


There is a console error caused by this line -

Failed prop type: Invalid prop containerStyles of type object supplied to Tooltip, expected an array.
at Tooltip (webpack-internal:///./src/components/Tooltip/index.js:49:86)
at withWindowDimensions(Tooltip)
at div
at eval (webpack-internal:///./node_modules/@expensify/react-native-web/dist/exports/View/index.js:52:25)
at Pressable (webpack-internal:///./node_modules/@expensify/react-native-web/dist/exports/Pressable/index.js:40:24)
at PressableWithDelayToggle (webpack-internal:///./src/components/PressableWithDelayToggle.js:94:29)

rushatgabhane · 2023-05-25T10:51:58Z

@BeeMargarida On Android I'm getting this weird bug where the recovery codes overflow.
Device - Pixel 5

Can you repro this?

BeeMargarida · 2023-05-25T18:03:24Z

I'm currently OOO until 1st of June, but @thiagobrez will take it from me

thiagobrez · 2023-05-29T08:15:10Z

Hey! Looking into this now

thiagobrez · 2023-05-29T09:29:52Z

Hey @rushatgabhane!

This comment should describe when / why would we use this prop

There is a console error caused by this line -

These 2 are done, just pushed the fix ✅

On Android I'm getting this weird bug where the recovery codes overflow.
Device - Pixel 5

This one is being fixed by this PR: #19260

Let me know what you think 🙌🏻

MonilBhavsar · 2023-05-30T07:02:20Z

@rushatgabhane would you be able to take a look today, so we can merge this 🚀

rushatgabhane · 2023-05-30T11:01:11Z

@thiagobrez thank you!

rushatgabhane

@MonilBhavsar LGTM!

MonilBhavsar · 2023-05-31T07:33:31Z

src/components/Button/index.js

                        {textComponent}
                    </View>
                    {this.props.shouldShowRightIcon && (
-                        <View style={styles.justifyContentCenter}>
+                        <View style={[styles.justifyContentCenter, styles.ml1, ...this.props.iconStyles]}>


Looks like this has caused issues in such button components

@MonilBhavsar Seems like the left icon styles were also being applied to the right icon. Fixed ✅

…_with_delay

MonilBhavsar · 2023-06-01T10:05:12Z

@thiagobrez the app crashes when we go to workspace > any workspace > bills. Could you please check. Thanks

BeeMargarida · 2023-06-02T08:55:17Z

the app crashes when we go to workspace > any workspace > bills

@MonilBhavsar Should be fixed now!

…_with_delay

MonilBhavsar · 2023-06-05T11:31:16Z

Sorry for not noticing earlier. But while we're here, can we please also update the "Copy" button inside verify page, to be pressable with feedack.

BeeMargarida · 2023-06-05T11:43:01Z

@MonilBhavsar Updated!

Screen.Recording.2023-06-05.at.12.41.10.mov

MonilBhavsar · 2023-06-05T11:59:34Z

src/pages/settings/Security/TwoFactorAuth/VerifyPage.js

                                onPress={() => Clipboard.setString(props.account.twoFactorAuthSecretKey)}
-                                medium
+                                styles={[styles.button, styles.buttonMedium, styles.twoFactorAuthCodesButton]}


Thanks for the change!
I wonder if we can remove the minimum width property from styles.twoFactorAuthCodesButton here as button looks wider. @shawnborton would like to hear your thoughts

I suppose we can get rid of it here, yeah.

Thanks! @BeeMargarida can we please remove styles.twoFactorAuthCodesButton. Thanks!

@MonilBhavsar Done!

@MonilBhavsar @BeeMargarida I believe this minWidth was there to keep the width of these 2 buttons consistent (per design). Maybe we could remove only from the copy button, not from the whole style definition

Oops, just saw that Ana did exactly that. Ignore me!

MonilBhavsar

Thanks! 🚀

OSBotify · 2023-06-05T15:24:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-05T19:24:53Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-07T03:28:43Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-07T13:20:22Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

rushatgabhane · 2023-08-03T04:53:38Z

src/components/PressableWithDelayToggle.js

+                                        fill={StyleUtils.getIconFillColor(getButtonState(hovered, pressed, props.isDelayButtonStateComplete))}
+                                        style={props.iconStyles}
+                                        width={variables.iconSizeSmall}
+                                        height={variables.iconSizeSmall}


Hi, we forgot to pass props.inline to <Icon /> causing #22259

mollfpr · 2023-09-06T04:39:15Z

src/components/CopyTextToClipboard.js

                onPress={this.copyToClipboard}
-                style={[styles.flexRow, styles.cursorPointer]}
-                suppressHighlighting


Coming from #24591

We are missing the prop suppressHighlighting if the PressableWithDelayToggle uses the Text component.

BeeMargarida added 7 commits May 19, 2023 15:45

feat: PressableWithDelayToggle component

ad3cec2

feat: use PressableWithDelayToggle in CodesPage

0fd1221

feat: use PressableWithDelayToggle in CopyTextToClipboard

b0548a8

feat: support no icon in PressableWithDelayToggle

43c1e4d

fix: button bug that shows no iconRight if no icon is defined

15572ba

fix: fix for inlining into text due to RN limitation

152daf1

style: add missing documentation for props

c07527c

gedu reviewed May 22, 2023

View reviewed changes

src/components/PressableWithDelayToggle.js Outdated Show resolved Hide resolved

thiagobrez previously approved these changes May 22, 2023

View reviewed changes

refactor: store wrapper in component

4678f93

BeeMargarida dismissed thiagobrez’s stale review via 4678f93 May 23, 2023 07:51

ArekChr reviewed May 23, 2023

View reviewed changes

fix: re-order style and prop order

e68fc31

BeeMargarida marked this pull request as ready for review May 23, 2023 09:06

BeeMargarida requested a review from a team as a code owner May 23, 2023 09:06

melvin-bot bot requested review from MonilBhavsar and rushatgabhane and removed request for a team May 23, 2023 09:06

rushatgabhane suggested changes May 25, 2023

View reviewed changes

fix: improve prop comment and remove console error

db1dde0

rushatgabhane previously approved these changes May 30, 2023

View reviewed changes

MonilBhavsar reviewed May 31, 2023

View reviewed changes

thiagobrez added 2 commits May 31, 2023 09:42

Merge branch 'main' into improvement/19180-button_with_press_feedback…

5bda66e

…_with_delay

chore: fix Button iconRight styles

6488188

thiagobrez dismissed rushatgabhane’s stale review via 6488188 May 31, 2023 14:12

fix: invalid children element for tooltip

5e98507

Merge branch 'main' into improvement/19180-button_with_press_feedback…

ef3cb4f

…_with_delay

feat: use PressableWithDelayToggle in 2FA verify page

ba6db16

MonilBhavsar reviewed Jun 5, 2023

View reviewed changes

fix: remove twoFactorAuthCodesButton style from verify page

67758d7

MonilBhavsar approved these changes Jun 5, 2023

View reviewed changes

MonilBhavsar merged commit 9a3c9b6 into Expensify:main Jun 5, 2023

OSBotify mentioned this pull request Jun 5, 2023

Deploy Checklist: New Expensify 2023-06-05 #20195

Closed

51 tasks

melvin-bot bot mentioned this pull request Jun 6, 2023

[HOLD for payment 2023-06-13] Polish codes screen in managing 2FA in newdot #19180

Closed

chiragxarora mentioned this pull request Jun 19, 2023

[Hold for payment 2023-07-05][$1000] copy to clipboard tooltip is missing in Contact methods #21074

Closed

6 tasks

rushatgabhane reviewed Aug 3, 2023

View reviewed changes

rushatgabhane mentioned this pull request Aug 3, 2023

[HOLD for payment 2023-08-07] [$1000] Android - Copy icon is not aligned with other texts #22259

Closed

6 tasks

mollfpr mentioned this pull request Aug 24, 2023

[HOLD for payment 2023-09-06] [$1000] Workspace - Highlight on text is displayed when email is pressed in Bills screen #24591

Closed

6 tasks

mollfpr reviewed Sep 6, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use pressable with press feedback #19391

feat: use pressable with press feedback #19391

BeeMargarida commented May 22, 2023

thiagobrez left a comment

ArekChr left a comment

melvin-bot bot commented May 23, 2023

rushatgabhane commented May 25, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane May 25, 2023

rushatgabhane May 25, 2023

rushatgabhane commented May 25, 2023 •

edited

Loading

BeeMargarida commented May 25, 2023

thiagobrez commented May 29, 2023

thiagobrez commented May 29, 2023

MonilBhavsar commented May 30, 2023

rushatgabhane commented May 30, 2023

rushatgabhane left a comment

MonilBhavsar May 31, 2023

thiagobrez May 31, 2023

MonilBhavsar commented Jun 1, 2023

BeeMargarida commented Jun 2, 2023

MonilBhavsar commented Jun 5, 2023

BeeMargarida commented Jun 5, 2023

MonilBhavsar Jun 5, 2023

shawnborton Jun 5, 2023

MonilBhavsar Jun 5, 2023

BeeMargarida Jun 5, 2023 •

edited

Loading

thiagobrez Jun 5, 2023

thiagobrez Jun 5, 2023

MonilBhavsar left a comment

OSBotify commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

rushatgabhane Aug 3, 2023

mollfpr Sep 6, 2023

feat: use pressable with press feedback #19391

feat: use pressable with press feedback #19391

Conversation

BeeMargarida commented May 22, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

thiagobrez left a comment

Choose a reason for hiding this comment

ArekChr left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 23, 2023

rushatgabhane commented May 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rushatgabhane commented May 25, 2023 • edited Loading

BeeMargarida commented May 25, 2023

thiagobrez commented May 29, 2023

thiagobrez commented May 29, 2023

MonilBhavsar commented May 30, 2023

rushatgabhane commented May 30, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MonilBhavsar commented Jun 1, 2023

BeeMargarida commented Jun 2, 2023

MonilBhavsar commented Jun 5, 2023

BeeMargarida commented Jun 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BeeMargarida Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MonilBhavsar left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rushatgabhane commented May 25, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented May 25, 2023 •

edited

Loading

BeeMargarida Jun 5, 2023 •

edited

Loading