Coarse-grained runtime statistics #1067
Conversation
| call json_get(params, 'case.timestep', dt) | ||
| call json_get(params, 'case.end_time', end_time) | ||
|
|
||
| this%total_steps_ = ceiling(end_time / dt) |
There was a problem hiding this comment.
Assumes constant dt, right? We should probably avoid this in new code.
|
|
||
| this%total_steps_ = ceiling(end_time / dt) | ||
|
|
||
| allocate(this%data(this%total_steps_, size(RT_STATS_ID))) |
There was a problem hiding this comment.
I guess to avoid constant dt we would need data to a sort of dynamic array which gets expanded on demand. end_time / dt would be a good initial size, I guess.
| logical, private :: enabled_ | ||
| real(kind=dp), private, allocatable :: elapsed_time_(:) | ||
| integer, private, allocatable :: nsamples_(:) | ||
| integer, private :: start_step_ | ||
| integer, private :: total_steps_ | ||
| real(kind=dp), allocatable :: data(:,:) | ||
| contains | ||
| procedure, pass(this) :: init => runtime_stats_init | ||
| procedure, pass(this) :: record => runtime_stats_record | ||
| procedure, pass(this) :: report => runtime_stats_report |
There was a problem hiding this comment.
Docstring for each component and TBP, please :-). Also, param-doctrings for the TBPs further below.
| @@ -120,6 +126,7 @@ subroutine neko_solve(C) | |||
| 'Elapsed time (s):', end_time-start_time_org, ' Step time:', & | |||
| end_time-start_time | |||
| call neko_log%end_section(log_buf) | |||
| call rt_stats%record(RT_STATS_FLUID, end_time-start_time, t, tstep) | |||
There was a problem hiding this comment.
Would it be better to have the objects in question own their own rt_stats and update them? That would clean the main time-loop and allow for more granularity, e.g. one could enable for fluid and disable for scalar. We would only need an extra subroutine to pull in the stuff from all the objects and print the summary.
There was a problem hiding this comment.
Great idea! I'll restructure it
Add optional collection of coarse-grained runtime statistics for a simulation.
Enabled via the case file, e.g.