Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Device count #1375

Merged
merged 13 commits into from
Aug 28, 2024
Merged

Conversation

timfelle
Copy link
Collaborator

@timfelle timfelle commented Jul 18, 2024

Adding a unified interface to get the number of available backend devices.

In PR #1358 it was mentioned this could be used to move the check out of initialization. Where should that be done then?

@timfelle timfelle added the enhancement New feature or request label Jul 18, 2024
@timfelle timfelle self-assigned this Jul 18, 2024
@timfelle timfelle added the GPU GPU label Jul 18, 2024
@timfelle timfelle changed the title Feature/Dvice count Feature/Device count Jul 18, 2024
@njansson
Copy link
Collaborator

Isn't the indentation for new line a bit off, now we have a several fixes which is not what eMacs Fortran mode (which we follow) gives ?

@timofeymukha
Copy link
Collaborator

Is there a comprehensive ruleset of eMacs Fortran mode written somewhere when it comes to indentation after &?

@timofeymukha
Copy link
Collaborator

@timfelle regarding the check location, maybe somewhere in the beginning of neko_init ?

@timfelle
Copy link
Collaborator Author

I have looked into the line continuation. Judging from https://emacsdocs.org/docs/emacs/Fortran-Indent
It seem the continuation lines must be indented by 5 additional space compared to the current context.

Is that what we should follow @njansson? Because then i will update the documentation to reflect that.

@njansson
Copy link
Collaborator

I have looked into the line continuation. Judging from https://emacsdocs.org/docs/emacs/Fortran-Indent It seem the continuation lines must be indented by 5 additional space compared to the current context.

Is that what we should follow @njansson? Because then i will update the documentation to reflect that.

I would say yes. It also makes it consistent with most of the continuation lines in Neko then, which followed their style.

@timfelle
Copy link
Collaborator Author

Done, @njansson and @timofeymukha
However, Depends on #1391 to be merged

@njansson
Copy link
Collaborator

@timfelle Should we merge this one?

@timfelle
Copy link
Collaborator Author

@timfelle Should we merge this one?

Should be good yes

@njansson njansson merged commit f65a55b into ExtremeFLOW:develop Aug 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GPU GPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants