-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic vector/matrix operations #1376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/vector_ops
vbaconnet
added
enhancement
New feature or request
GPU
GPU
NVIDIA
NVIDIA GPUs and CUDA
AMD
AMD GPUs and HIP
OpenCL
OpenCL backend
labels
Jul 18, 2024
Not sure I understand what is wrong with the checks, if someone could take a look that would be much appreciated :) |
I would say we should merge this, and I can take upon me to fix the generic interface (+ ensure correct inlining in key kernels) |
njansson
approved these changes
Aug 22, 2024
timfelle
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AMD
AMD GPUs and HIP
enhancement
New feature or request
GPU
GPU
NVIDIA
NVIDIA GPUs and CUDA
OpenCL
OpenCL backend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overloading some operators for the
vector_t
andmatrix_t
classes, and add some additional math routines likecadd2
,device_cadd2
(a(i) = b(i) + c) anddevice_add3
(a(i) = b(i) + c(i)).This is to facilitate the usage of
vector_t
andmatrix_t
especially with GPUs. This should not break anything since it's just adding to what we have, only thing I changed is the intent on some arguments insub3
andadd3
, @njansson will this be a problem?Tested on cpus, nvidia, and amd gpus. Not tested with OpenCL.
Contrary to the assignment operator where if we do
v = w
andv%x
is already allocated, we freev
and re-initialize it to have the same size asw
, all the other operations assume that if one doesv = a + b
andv
is already allocated thenv
should have the same size asb
anda
. So there is no implicit reallocation except for the assignment operator.