-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output the commands used with genmeshbox in a separate log file #1381
Conversation
Naive question: would it be easier / better to print things into stdout by default, and then if the user wants it logged the standard linux output redirection can be used? |
The benefit of this approach is that one could separate run time messages from the parameters more easily. Just a little fever dream: Once that is done, you could even put the specification into the casefile and have the neko driver call genmeshbox if the mesh specifications are there, but the mesh is not. |
That does sound really nice :) Unfortunately I am not so well-versed with the json fortran stuff and perhaps this will be a bit more work than I can do for now since this was supposed to be a quick fix... But I agree it would be super nice. I would suggest we add the json stuff as todo and either merge or we close this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a log that shows which parameters were used with genmeshbox, to have a trace.