Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output the commands used with genmeshbox in a separate log file #1381

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

vbaconnet
Copy link
Collaborator

Added a log that shows which parameters were used with genmeshbox, to have a trace.

@vbaconnet vbaconnet added the enhancement New feature or request label Jul 19, 2024
@timofeymukha
Copy link
Collaborator

Naive question: would it be easier / better to print things into stdout by default, and then if the user wants it logged the standard linux output redirection can be used?

@timfelle
Copy link
Collaborator

Naive question: would it be easier / better to print things into stdout by default, and then if the user wants it logged the standard linux output redirection can be used?

The benefit of this approach is that one could separate run time messages from the parameters more easily.

Just a little fever dream:
A cool feature based on this could be to dump it as a json, which could then be reinserted into genmeshbox. This could allow us to recreate the exact mesh and the json could then follow the dataset so you dont have to remember how you generated it.

Once that is done, you could even put the specification into the casefile and have the neko driver call genmeshbox if the mesh specifications are there, but the mesh is not.

@vbaconnet
Copy link
Collaborator Author

Just a little fever dream: A cool feature based on this could be to dump it as a json, which could then be reinserted into genmeshbox. This could allow us to recreate the exact mesh and the json could then follow the dataset so you dont have to remember how you generated it.

Once that is done, you could even put the specification into the casefile and have the neko driver call genmeshbox if the mesh specifications are there, but the mesh is not.

That does sound really nice :) Unfortunately I am not so well-versed with the json fortran stuff and perhaps this will be a bit more work than I can do for now since this was supposed to be a quick fix... But I agree it would be super nice.

I would suggest we add the json stuff as todo and either merge or we close this PR :)

@timfelle timfelle mentioned this pull request Jul 22, 2024
3 tasks
@njansson njansson enabled auto-merge July 23, 2024 13:31
Copy link
Collaborator

@MartinKarp MartinKarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge this one before before #1407 @adperezm?

@adperezm
Copy link
Collaborator

Ok to merge this one before before #1407 @adperezm?

Yeah, that sounds good

@njansson njansson merged commit 029c686 into develop Aug 16, 2024
27 checks passed
@njansson njansson deleted the feature/log-genmeshbox branch August 16, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🍻 Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants