Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isisd: IS-IS over tunnel (GRE, GENEVE) #12979

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

miegl
Copy link
Contributor

@miegl miegl commented Mar 12, 2023

This patch introduces a new BFP filter in isis_pfpacket.c, which in addition to IS-IS over LLC also permits IS-IS over Ethertype 0x00fe. This makes IS-IS work over tunnels such as GRE.

Tested IS-IS over Ethernet, IS-IS over GRE and IS-IS over GENEVE (GENEVE requires upstreaming a kernel patch).

Resolves #2330 (may need setting isis network point-to-point).

@vjardin
Copy link
Contributor

vjardin commented Mar 12, 2023

Which kernel patch is needed for GENEVE case ? Please, share a URL.

@miegl
Copy link
Contributor Author

miegl commented Mar 12, 2023

These are the kernel patches in question:
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

With these two patches, a GENEVE tunnel created with innerprotoinherit (man 8 ip-link) can carry IS-IS traffic (byte 0x83) with Protocol Type 0x00fe, without the overhead of Ethernet. One usecase for this is a virtual MPLS/SR-MPLS network, as GENEVE can carry MPLS and IS-IS directly, without Ethernet.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10121/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for isis_pfpacket.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #51: FILE: /tmp/f1-3116727/isis_pfpacket.c:51:

@riw777 riw777 self-requested a review March 14, 2023 14:04
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 0fdd574 into FRRouting:master Mar 14, 2023
@clay584
Copy link

clay584 commented Jun 1, 2023

@riw777 Do you know when this will be pulled into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't enable ISIS over GRE interface
5 participants