Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/v0.7.0 #631

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Dev/v0.7.0 #631

merged 3 commits into from
Oct 31, 2022

Conversation

fedml-alex
Copy link
Collaborator

No description provided.

@gitguardian
Copy link

gitguardian bot commented Oct 31, 2022

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4621627 Generic High Entropy Secret d0766b7 python/examples/cross_silo/mqtt_s3_fedavg_mnist_lr_example/custom_data_and_model/config/fedml_config.yaml View secret
4621627 Generic High Entropy Secret a9d65e7 python/examples/cross_silo/mqtt_s3_fedavg_mnist_lr_example/custom_data_and_model/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret 6b70b89 python/examples/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/custom_data_and_model/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret 6b70b89 python/examples/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/one_line/config/fedml_config.yaml View secret
4672198 Generic High Entropy Secret 6b70b89 python/examples/cross_silo/mqtt_web3storage_fedavg_mnist_lr_example/step_by_step/config/fedml_config.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@fedml-alex fedml-alex merged commit f8bd2ba into master Oct 31, 2022
fedml-alex added a commit that referenced this pull request Mar 31, 2023
fedml-alex added a commit that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant