Fix Quadrature rule docs and syms #1007
Conversation
There was a problem hiding this comment.
Nice that you found this!
Since we probably don't want to change the defaults in the future, are these reasonable defaults? Seems strange to switch at order = 8?
(Side-note: Also looks like dispatching on a type would be nicer as @fredrikekre suggested, but that would be a different PR)
Thanks, took me a while to realize too tbh.
Actually I am really not sure about the rule or why it works in the in first place, because it comes with negative weights. I am pretty sure this can cause some trouble, but I cannot pin down why. See e.g. https://www.math.ntnu.no/emner/TMA4130/2021h/lectures/GaussQuadrature.pdf . But on the other hand rules with positive weights have more points in general.
I am not super sure about this. I think it would also be nice to provide extensions which add new quadrature rules. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 93.20% 93.23% +0.02%
==========================================
Files 38 38
Lines 5816 5879 +63
==========================================
+ Hits 5421 5481 +60
- Misses 395 398 +3 ☔ View full report in Codecov by Sentry. |
|
The triangle ones are from #514 (comment) (unless you found it already). |
Yes, and going into the basics source code tracking down the call graph manually I arrived at a call to Gauss-Jacobi generators. |
|
Someone should verify this independently and then it should be good to go. |
termi-official
added
the
awaiting review
| It defaults to the default rules for the individual face reference elements. Elements with mixed facet types | ||
| requires passing a tuple of symbols for the rule, one for each facet type. |
There was a problem hiding this comment.
The ordering of the quad_rule_type is not clear/obvious here. I'm not sure if we want to introduce this as public API now?
Would it be better (at least for now), to rather say that if you want non-default rules, you need to pass the face_rules manually?
There was a problem hiding this comment.
Indeed. I also struggle a bit with the wording in the docstring. It is essentially implemented as "first triangle, then quad" in the sense of "increasing size".
Following the discussion in #1001 I just noticed that some references for the quadrature roles and the doc strings were not correct. This PR fixes both.