Rename VTKFile to VTKGridFile #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 93.20% 93.17% -0.04%
==========================================
Files 38 38
Lines 5816 5818 +2
==========================================
Hits 5421 5421
- Misses 395 397 +2 ☔ View full report in Codecov by Sentry. |
fredrikekre
reviewed
Jul 4, 2024
| @@ -427,8 +427,8 @@ more discussion). | |||
| omitting type piracy, ([#835][github-835]) implemented `isequal` and `hash` for `BoundaryIndex` datatypes. | |||
|
|
|||
| - **VTK export**: Ferrite no longer extends methods from `WriteVTK.jl`, instead the new types | |||
| `VTKFile` and `VTKFileCollection` should be used instead. New methods exists for writing to | |||
| a `VTKFile`, e.g. `write_solution`, `write_cell_data`, `write_node_data`, and `write_projection`. | |||
| `VTKGridFile` and `VTKFileCollection` should be used instead. New methods exists for writing to | |||
There was a problem hiding this comment.
Suggested change
| `VTKGridFile` and `VTKFileCollection` should be used instead. New methods exists for writing to | |
| `VTKGridFile` and `VTKCollectionFile` should be used instead. New methods exists for writing to |
for symmetry?
There was a problem hiding this comment.
See suggestion to remove completely here: #1015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1004
Does not solve #1004, but as pointed out by @termi-official, it is clear that having
Ferrite.VTKFile(concrete type, wrapper ofWriteVTK.DatasetFile) being something different thanWriteVTK.VTKFile(abstract supertype of mostWriteVTKfiletypes) can be very confusing.