-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstraction layer around vtk export #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 93.56% 93.86% +0.29%
==========================================
Files 36 36
Lines 5272 5313 +41
==========================================
+ Hits 4933 4987 +54
+ Misses 339 326 -13 ☔ View full report in Codecov by Sentry. |
having something like |
fredrikekre
reviewed
Jul 18, 2023
Merged
fredrikekre
approved these changes
May 19, 2024
koehlerson
reviewed
May 22, 2024
KnutAM
added a commit
that referenced
this pull request
May 23, 2024
Adressing changes in #692, #789, and #914 --------- Co-authored-by: Fredrik Ekre <[email protected]>
KnutAM
added a commit
that referenced
this pull request
Aug 10, 2024
Restores pre #692 functionality for collection files by removing VTKFileCollection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #278 (replaces #691, xref #686)
Following the discussion in #691, this PR introduces an abstraction layer for exporting from Ferrite to VTK. With this PR, no functions from
WriteVTK.jl
should be called directly by the user. (If still needed for special/custom reasons, it is possible by accessing the internal methods and or thevtk
field inVTKFile
)Using
vtk_grid
with anAbstractGrid
orAbstractDofHandler
will error telling how to upgradeMain motivations
The new workflow is
or alternatively
For writing paraview collections, the workflow is
Alternatively,