Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml oauth #17

Merged
merged 6 commits into from
May 15, 2024
Merged

Fix yaml oauth #17

merged 6 commits into from
May 15, 2024

Conversation

muhammadn
Copy link
Collaborator

@muhammadn muhammadn commented Apr 26, 2024

Describe your changes

  1. Fixes the yaml parsing issue
  2. Remove oauth from firetail logging since firetail endpoint does not accept oauth as schema.

Issue ticket number and link

Checklist before requesting a review

  • I have resolved any merge conflicts
  • I have run tests locally and they pass
  • I have linted and auto-formatted the code
  • If there is new or changed functionality, I have added/updated the tests
  • If there is new or changed functionality, I have added/updated the documentation

lib/firetail.rb Outdated Show resolved Hide resolved
examples/rails/config/firetail.yml Outdated Show resolved Hide resolved
lib/generators/firetail/install/templates/firetail.yml Outdated Show resolved Hide resolved
rileyfiretail
rileyfiretail previously approved these changes Apr 29, 2024
@muhammadn muhammadn dismissed rileyfiretail’s stale review April 29, 2024 18:06

The merge-base changed after approval.

rileyfiretail
rileyfiretail previously approved these changes Apr 29, 2024
1. Remove oauth in the logging
2. Fix the firetail.yml not loading properly
@rileyfiretail rileyfiretail merged commit eb3d632 into main May 15, 2024
5 checks passed
@rileyfiretail rileyfiretail deleted the fix-yaml-oauth branch May 15, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants