insecure content loaded by pnotify

[vajonam]

Looks like pnotify is loading some content like icons from

http://sciactive.com/pnotify/includes/desktop/error.png

I am running octorprint behind a https reverse proxy. But loading this resource causes it to become an unsecure page as its loading mixed conent.

to reproduce

Insect the tab with chrome, and cancel a print half way and you see a pnotify toast, and in the network dialog you can see the inscure load of the icon.

[vajonam]

[FormerLurker]

Wow, nice catch! The pnotify js code is loaded by OctoPrint, so do you see the same thing without Octolapse enabled? If not, perhaps I'm using some functionality OctoPrint does not. In any case, I'll look into this and see if I can spot the part that loads this image.

[vajonam]

I have not noticed the pnotify errors issues prior to 0.4.0 octolapse. 0.3.4 did not have this issue. It happens when there a toast notification to be shown.

[FormerLurker]

I've tracked this down to OctoPrint/src/octoprint/static/js/lib/pnotify/pnotify.desktop.min.js. It looks like that icon is a fallback if one is not specified. I will look for a suitable icon for replacement.

[vajonam]

Just changing it to https works. If you want to use that and include in octolapse.

…

On Tue, Apr 14, 2020 at 6:24 PM FormerLurker ***@***.***> wrote: I've tracked this down to OctoPrint/src/octoprint/static/js/lib/pnotify/pnotify.desktop.min.js. It looks like that icon is a fallback if one is not specified. I will look for a suitable icon for replacement. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#499 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFHNKPAXTALOYGKKYHKFDRMTPC3ANCNFSM4MHL4VUQ> .

[FormerLurker]

Quick update: still trying to deal with this, but haven't had a lot of time. Will be spending time on it over the weekend. Thanks for your patience.

[vajonam]

Thanks.

…

On Wed, May 6, 2020 at 11:38 AM FormerLurker ***@***.***> wrote: Quick update: still trying to deal with this, but haven't had a lot of time. Will be spending time on it over the weekend. Thanks for your patience. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#499 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFHNOESTVIUECBCS4B6W3RQF76VANCNFSM4MHL4VUQ> .

[FormerLurker]

This should be solved in the devel branch. I basically turned all of the desktop notifications off. They are unnecessary anyway. Let me know if you are able to try it out.

[vajonam]

I pulled and installed devel.zip from github, looks good. I don't see issues so far. I will keep an eye out for it. you can close this bug for now. I will re-open if if its not resolved. or something else "pops" up.