Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the PRO icons #234

Closed
saffabook opened this issue Mar 12, 2020 · 7 comments · Fixed by #238
Closed

using the PRO icons #234

saffabook opened this issue Mar 12, 2020 · 7 comments · Fixed by #238

Comments

@saffabook
Copy link

Describe the problem

I have done the installation and everything works as expected, however, I cannot get the Pro to work as well.

I followed this guide https://github.com/FortAwesome/angular-fontawesome

My pro folder looks like this though.

image

As you can see, I have the pro-solid folder, but no ref to the acorn icon.

I have also tried a new ng add @fortawesome/[email protected]

And end up with this screen.
image

Why would this be?

@devoto13
Copy link
Collaborator

You have installed the old and deprecated icon package. Please check this documentation to learn how to install and use correct packages.

Note that you'll need to configure your .npmrc to be able to install Pro packages.

Also you should use specific angular-fontawesome version, which is compatible with your Angular version. See Compatibility table. This may be the reason why ng add fails. If you use the correct version and still experience the problem with ng add, please provide a minimal reproduction and I'll investigate it further.

@saffabook
Copy link
Author

Hi there, I have installed the pro now and works as you explained. Thanks for pointing that out.

I do have angular 9 so compatibility should work with ng add @fortawesome/[email protected] ?

Anyways, thank you for everything.

@devoto13
Copy link
Collaborator

devoto13 commented Mar 14, 2020

Yes, ng add should work with Angular 9. Please provide reproduction steps, so I can debug and fix this bug.

@nephi5
Copy link

nephi5 commented Mar 16, 2020

Hi, how would you go about using the pro icons when you are behind a corporate proxy?

@devoto13
Copy link
Collaborator

@nephi5 It's impossible to answer your question without more details. Please open a new issue and describe step by step what you're doing and what is the error message you receive. Normally everything should just work as long as npm.fontawesome.com domain is not blacklisted by your proxy.

@nephi5
Copy link

nephi5 commented Mar 16, 2020

Hi @devoto13 - thanks for the quick answer. Our company does not use blacklists, they white-list only a handful of domains. They won't allow a domain like npm.fontawesome.com to be white-listed. Currently we are manually downloading and hosting the fontawesome pro assets. Is there a way I could point to those resources?

@devoto13
Copy link
Collaborator

devoto13 commented Mar 16, 2020

@nephi5 Well, Pro packages are only available from npm.fontawesome.com. If you can't access it, this means you can not install these NPM packages.

But I still don't completely understand what you're trying to do. What exactly do you mean by "point to those resources"? Do you want a direct link to download an NPM package?

devoto13 added a commit to devoto13/angular-fontawesome that referenced this issue Mar 27, 2020
`angular-fontawesome` abuses `@schematics/angular` instead of re-implementing some AST manipulations. The problem is that source file is parsed by the workspace's TypeScript version (3.7.5 in this case), but `@schematics/angular` bundles TypeScript 3.8.3 and assumes that AST was produced by 3.8.3. The AST is incompatible, hence the crash.

The solution is to use TypeScript bundled with `@schematics/angular` to parse the source file instead of using workspace's version.

Fixes FortAwesome#237
Fixed FortAwesome#234
devoto13 added a commit that referenced this issue Mar 27, 2020
`angular-fontawesome` abuses `@schematics/angular` instead of re-implementing some AST manipulations. The problem is that source file is parsed by the workspace's TypeScript version (3.7.5 in this case), but `@schematics/angular` bundles TypeScript 3.8.3 and assumes that AST was produced by 3.8.3. The AST is incompatible, hence the crash.

The solution is to use TypeScript bundled with `@schematics/angular` to parse the source file instead of using workspace's version.

Fixes #237
Fixed #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants