Always load the GPU functionality #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
requested review from
apaloczy,
BrodiePearson,
glwagner,
jbisits and
liasiegelman
jbisits
approved these changes
Aug 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now GPU functionality was only loaded if CUDA was enabled. But this was creating trouble because it was only done during first precompilation and if you happened to precompile on a machine without GPU or on a cluster on a login node that didn't see the GPU then GPU functionality was not loaded.
This was a leftover from an era when
using CUDAwould break on a machine without GPU. This era is long gone now.This PR loads GPU functionality regardless!
@liasiegelman I believe this will solve some of the problems both of us have had in the past.