Add LSRK54 time stepping method #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
reviewed
Oct 23, 2022
navidcy
reviewed
Oct 23, 2022
|
Should we include the |
+ change Fi -> RHS, fix docstrings, cleanup
|
I made a few changes @doraemonho. Have a look and let me know what you think. |
It is workable but I am not sure if the solution is stable in the combination with the filter + low storage method. |
|
@navidcy I changed the coef. values to rational form and also tested once. Could you check if the formatting is correct or not? |
navidcy
reviewed
Oct 23, 2022
|
When tests pass I'll merge. |
|
@doraemonho welcome to FourierFlows contributors ;) |
It is my pleasure : D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a 4th-order 5-stages 2-storage Runge-Kutta timestepper,
LSRK54.Closes #334