Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalization from uh -> ûₖ #343

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Fix normalization from uh -> ûₖ #343

merged 2 commits into from
Dec 9, 2022

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Dec 9, 2022

The example demonstrating the proper way to normalize results from FFT to get $\hat{u}_k$ coefficients was wrong. Instead of $n_x e^{-i k x_0}$ the normalization factor is $n_x e^{i k x_0}$. When $x_0 = -\pi$ that error was overshadowed. I changed the example now to have $x_0 = -2\pi/3$.

@navidcy navidcy merged commit e700db9 into main Dec 9, 2022
@navidcy navidcy deleted the ncc/fix-normalization branch December 9, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants