Some clarifications, better docstrings, method for parsevalsum(fh, ::OneDGrid) + tests
#344
Conversation
navidcy
changed the title
parsevalsum(fh, ::OneDGrid) + tests
|
thanks @jbisits, have a look now? |
| where ``û_{𝐤} =`` `uh` ``/(`` `grid.nx` ``e^{- i 𝐤 ⋅ 𝐱₀})``, with ``𝐱₀`` the vector with components | ||
| the left-most position in each direction. | ||
| where ``û_{𝐤} =`` `uh` `` / (n_x e^{i 𝐤 ⋅ 𝐱₀})``, with ``𝐱₀`` the vector with components | ||
| the left-most position in each direction, e.g., for a 2D grid `(grid.x[1], grid.y[1])`. |
There was a problem hiding this comment.
I think the second half of this sentence (applies to all instances of this) could still be a little clearer. Maybe instead could be along the lines of
where
û_{𝐤} =uh/ (n_x e^{i 𝐤 ⋅ 𝐱₀})and𝐱₀is the vector with components in
the left-most position in each direction, ...
or
where
û_{𝐤} =uh/ (n_x e^{i 𝐤 ⋅ 𝐱₀}). The elements of the vector𝐱₀are the left-most position in each direction, ...
There was a problem hiding this comment.
Damn I merged before noticing this.
There was a problem hiding this comment.
No worries! I can do this or just add it to a list and do it in a future PR? It is not completely necessary, only if you think the change makes it clearer.
Looks good! |
No description provided.