Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilteredLSRK54TimeStepper + upgrades to Documenter v1 #360

Merged
merged 11 commits into from
Oct 19, 2023

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Oct 18, 2023

Closes #359

@navidcy navidcy requested a review from apaloczy October 18, 2023 13:54
@navidcy navidcy changed the title Add FilteredLSRK54TimeStepper Add FilteredLSRK54TimeStepper + upgrades to Documenter v1 Oct 18, 2023
@navidcy
Copy link
Member Author

navidcy commented Oct 18, 2023

@apaloczy I believe this is ready for review.

@apaloczy
Copy link
Collaborator

There's something wrong with the tests:

Timestepper tests: Error During Test at /var/lib/buildkite-agent/builds/gpuci-5/julialang/fourierflows-dot-jl/test/runtests.jl:218
--
MethodError: no method matching 
FilteredLSRK54TimeStepper(::FourierFlows.Equation{DataType, 
Vector{Float64}, Float64}, ::Float64, ::CPU)

I ran the tests on a local environment and they all passed, though.

@navidcy
Copy link
Member Author

navidcy commented Oct 19, 2023

Yeah I'm trying to fix it. At my laptop they fail locally as well.

@navidcy navidcy merged commit dd4a349 into main Oct 19, 2023
5 checks passed
@navidcy navidcy deleted the ncc-ap/filteredLSRK54 branch October 19, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilteredLSRK54TimeStepper appears to be missing
2 participants