-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer sidebar items #30
Conversation
lib/src/sidebarx_base.dart
Outdated
item.onTap?.call(); | ||
widget.controller.selectIndex(widget.items.length + | ||
widget.footerItems.length - | ||
index - | ||
1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part can be extracted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extract this code in method
selected: widget.controller.selectedIndex == | ||
widget.items.length + | ||
widget.footerItems.length - | ||
index - | ||
1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part same
Hello @DavidCatalano ! |
Per this issue outlining the feature details I am submitting this pull request after @Frezyx indicated it could be added.
Thanks for creating a really cool package!