close #48 - added hoverTextStyle property #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frezyx
requested changes
Jun 13, 2023
.vscode/settings.json
Outdated
Comment on lines
1
to
3
| { | ||
| "git-blame.gitWebUrl": "" | ||
| } |
There was a problem hiding this comment.
Can you remove this changes from pr?
lib/src/theme/sidebarx_theme.dart
Outdated
Comment on lines
22
to
23
| this.hoverColor, | ||
| this.hoverTextStyle}); |
lib/src/theme/sidebarx_theme.dart
Outdated
Comment on lines
185
to
186
| hoverColor: hoverColor ?? this.hoverColor, | ||
| hoverTextStyle: hoverTextStyle ?? this.hoverTextStyle); |
|
Hello @MaurizioSodano 👋 Please fix review issues and after that run command: flutter format lib/And I will merge it after changes |
|
Hello @Frezyx , happy to contribute. I hope everything is fine with this update. |
Frezyx
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the hoverTextStyle to change the SidebarXCell textStyle on hover