Use Material Inkwell + Add related theme options #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except splash color, which I kept transparent because it does not animate
getBoolean
changed the title
selectedHoverColor
Frezyx
approved these changes
Feb 15, 2024
|
Thanks for the approval. Before you merge, I just noticed a typo in the changelog. It should be |
getBoolean
commented
Feb 15, 2024
|
Alright, I'm happy with the code now |
|
This is getting stale, so I'm going close the PR. Feel free to take any of the changes and incorporate them into the codebase when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
InkWellinstead ofGestureDetectorforSidebarXCell, which addsa default hover color and a splash animation when pressed.
toggleButtonDecoration,secondaryHoverColor,splashColor,selectedSplashColor,highlightColor,selectedHighlightColor,focusColor, andselectedFocusColorproperties to
SidebarXThemehoverColor,highlightColor, andfocusColorHighlight, Focus, and Hover, and Splash colors
Default toggle button is now improved for keyboard tab navigation
