Fix an issue that allowed users to create private discussions with users who are blocking them #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaucau
changed the title
rafaucau
changed the title
rafaucau
changed the title
rafaucau
changed the title
rafaucau
changed the title
rafaucau
force-pushed
the
fix/privacy_settings
branch
from
193aacd
to
0339d15
Compare
davwheat
reviewed
Jul 31, 2022
There was a problem hiding this comment.
I think this is fine.
I see some other things which I want to question in the code, but nothing that wasn't already there before this PR, so I'm happy to get this merged.
Nowadays for our JS, we tend to prefer named functions rather than arrow ones. This is because it makes it easier to debug when issues occur (since DevTools will show the function name rather than "anonymous", for example).
Co-authored-by: David Wheatley <[email protected]>
|
@davwheat Ok, I changed this function |
davwheat
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
Changes proposed in this pull request:
This PR fixes an issue that allowed users to create private discussions with users who are blocking them.
Confirmed