Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix censor creation + some maintenance #32

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Fix censor creation + some maintenance #32

merged 4 commits into from
Jun 30, 2022

Conversation

dsevillamartin
Copy link
Member

Fixes #31

Changes proposed in this pull request:

  • Only use newline character instead of PHP_EOL for user-inputted strings
  • Run prettier
  • Add tsconfig for core typings, other JS script updates
  • Update .gitignore, add .gitattributes & fix README image link

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@evaleries
Copy link

Hello, sorry for discussing this here.
can you trim for each strings?

I mistakenly added empty line and got filtered by this extensions.

Thank you

@imorland imorland merged commit 434cd59 into master Jun 30, 2022
@imorland imorland deleted the ds/fix-censor-creation branch June 30, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter isn't working.
3 participants
@dsevillamartin @evaleries @imorland