New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrations assume flarum is already installed #37

Merged

imorland merged 1 commit into master from ds/fix-migrations-assume-flarum-installed

Oct 28, 2022

Member

dsevillamartin commented Oct 28, 2022

Relates to flarum/framework#3655

Changes proposed in this pull request:
Use Schema DB connection instead of resolving flarum.settings.
More info @ FriendsOfFlarum/reactions#55.

Confirmed

Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run composer test).


          fix: migrations assume flarum is already installed

bf791de

imorland approved these changes

View reviewed changes

imorland merged commit 020cc3e into master

imorland deleted the ds/fix-migrations-assume-flarum-installed branch

October 28, 2022 08:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet