-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add setting to only show icons on small screens #54
feat: add setting to only show icons on small screens #54
Conversation
@@ -68,6 +68,20 @@ | |||
width: auto; | |||
margin-right: 10px; | |||
} | |||
|
|||
@media (max-width: 1100px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easier to wrap both blocks with the when
clause rather than two separate ones?
Hi @SychO9, I have tried this update and I have encountered an error on one of my instances:
On a clean installation without any other extensions, it seems to work, so what could be the cause of this?... I have checked and there are no other installed extensions that use the Then I also realized that on small mobile devices (phone breakpoint) the icon is also hidden, even though the links are in the burger menu, and there it doesn't make sense to hide the label IMO. Finally, I find the settings name quite confusing, it would be much simpler to name it like this: "hide link label on tablet" (not "on mobile", as mentioned above. |
For the label and the icons issue: #57 (thanks for the report) For the first issue, it's hard to tell what could be wrong, it could be a type of extension that overrides certain core components. I would try disabling the most advanced extensions one at a time and see. |
Yeah, I now found the reason and could fix it: I was overriding the flarum.assets.factory. I could extend it instead of overriding it, that fixed the issue of the variable being undefined. |
Changes proposed in this pull request:
Links can overflow the header of the app, this PR adds a setting to only show icons on smaller screens.
Reviewers should focus on:
Screenshot
![Screenshot from 2023-02-01 13-03-00](https://user-images.githubusercontent.com/20267363/216037533-509b69a3-3977-4ede-94da-fd5079417e59.png)
Confirmed
composer test
).Required changes: