Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dropdown text on medium sizes #67

Conversation

jaggy
Copy link
Contributor

@jaggy jaggy commented Feb 23, 2024

This fixes an issue where the text is missing on the dropdown on tablet breakpoints when the "Show icons only on tablet screens" is toggled.
CleanShot 2024-02-23 at 23 45 54@2x

Changes proposed in this pull request:
This PR update the CSS to show the button text on dropdown links.

Screenshot
Here's how the fix looks after.
CleanShot 2024-02-23 at 23 45 22@2x

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test) No backend changes.

@luceos
Copy link
Contributor

luceos commented Feb 26, 2024

This fix is sponsored by Orion Browser by Kagi 👍

@imorland imorland merged commit 6c0d9aa into FriendsOfFlarum:master Feb 26, 2024
8 checks passed
@jaggy jaggy deleted the fix-missing-dropdown-text-on-medium-sizes branch April 12, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants