Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop newPollVote websocket message #38

Closed
clarkwinkelmann opened this issue Apr 8, 2021 · 0 comments
Closed

Drop newPollVote websocket message #38

clarkwinkelmann opened this issue Apr 8, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@clarkwinkelmann
Copy link
Member

As of version 0.3.3, the newPollVote message on the Pusher websocket is no longer used. Instead a new updatedPollOption is used.

Version 0.3.3 continues to broadcast the old message for backward compatibility, but we should remove it in a future version.

This issue is there to collect any comment from someone who might be using that message as part of their own integration. If there's no comment, I think we can assume it can be safely removed without any harm.
@clarkwinkelmann clarkwinkelmann added the enhancement New feature or request label Apr 8, 2021
dsevillamartin added a commit that referenced this issue Jul 6, 2023
@dsevillamartin
Drop 'newPollVote' websocket message
636eccb 
Fixes #38
@dsevillamartin dsevillamartin mentioned this issue Jul 6, 2023
Merged
2 tasks
dsevillamartin added a commit that referenced this issue Jul 9, 2023
@dsevillamartin
Drop 'newPollVote' websocket message
e5c03c9 
Fixes #38
dsevillamartin added a commit that referenced this issue Jul 12, 2023
@dsevillamartin
Drop 'newPollVote' websocket message
8f84a73 
Fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clarkwinkelmann